This repository was archived by the owner on May 7, 2024. It is now read-only.
Added auto-deploy npm script, browser-sync support - #2
Open
joshellington wants to merge 1 commit into
Open
Conversation
|
I've been using this for a couple of days now and I don't feel like it's quite there yet. Today, my machine really slowed down after leaving auto-deploy on the whole day. A better solution than using the watch cli may be to use watch programmatically. That way we could wait for a threshold of files in the dist folder (if there's always 9 files in a folder, then wait to run the deploy when those 9 files appear and not when the first one appears and then again each time another file is recreated in the dist folder). |
Author
|
I hear ya. It is definitely a blunt force approach right now.
Ideal scenario IMO would be to get it closer to the gulp tasks, which would
require binding the devcontainer closer to the theme/plugin. Not sure we
should re-wire that at this point.
I’ll investigate what other options we could pass to watch to slim it down
a bit. Could possibly only deploy changed files, versus the whole
directories. Or be more explicit about what it’s watching.
…On Fri, May 17, 2019 at 5:38 PM Ken Eucker ***@***.***> wrote:
I've been using this for a couple of days now and I don't feel like it's
quite there yet. Today, my machine really slowed down after leaving
auto-deploy on the whole day.
A better solution than using the watch cli may be to use watch
programmatically. That way we could wait for a threshold of files in the
dist folder (if there's always 9 files in a folder, then wait to run the
deploy when those 9 files appear and not when the first one appears and
then again each time another file is recreated in the dist folder).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2?email_source=notifications&email_token=AAAWSIWUIXE22XO4WOG3FBDPV5FZHA5CNFSM4HNO2JIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVWEGQI#issuecomment-493634369>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAWSIUIJEZTZNVN3YIAWJ3PV5FZHANCNFSM4HNO2JIA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.